Fix Prism Launcher detection for versions with suffixes#148
Open
fe-art wants to merge 1 commit intoaternosorg:masterfrom
Open
Fix Prism Launcher detection for versions with suffixes#148fe-art wants to merge 1 commit intoaternosorg:masterfrom
fe-art wants to merge 1 commit intoaternosorg:masterfrom
Conversation
|
|
fe-art
force-pushed
the
prism-launcher-detection-fix
branch
from
08d9e5e to
1d10adf
Compare
JulianVennen
requested changes
May 6, 2026
|
|
||
| PrismLauncherClientLog::class, | ||
| MinecraftLauncherClientLog::class, | ||
| CustomSkinLoaderClientLog::class, |
Member
There was a problem hiding this comment.
These being at the bottom was very much intentional. Since prism prints the game output to the launcher log, most of the file (and most of the detectable issues and information) are probably from the mod loader.
Therefore we want a file which matches both prism launcher and fabric to be recognized as fabric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism Launcher recently started appending
(official)to the version line (e.g.Prism Launcher version: 10.0.5 (official)), which broke detection because the regex expected the line to end right after the version number. Also moved launcher-specific detectors before generic client detectors to prevent shadowing.